From b8f3d4f3b7366ef6df583eba7f2694ba09131f88 Mon Sep 17 00:00:00 2001 From: fanxb Date: Fri, 20 Aug 2021 14:25:34 +0800 Subject: [PATCH] =?UTF-8?q?refactor:=E4=BB=A3=E7=A0=81=E8=A7=84=E8=8C=83?= =?UTF-8?q?=E4=BF=AE=E6=94=B9?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../bookmark/business/api/BookmarkApi.java | 1 + .../fanxb/bookmark/business/api/UserApi.java | 4 ++++ .../consumer/BookmarkDeleteEsConsumer.java | 3 ++- .../controller/BookmarkBackupController.java | 4 ++-- .../business/bookmark/dao/BookmarkDao.java | 24 +++++++++++++++---- .../business/bookmark/entity/PinYinBody.java | 3 ++- .../service/BookmarkBackupService.java | 4 ++-- .../bookmark/service/BookmarkService.java | 6 ++++- .../bookmark/service/PinYinService.java | 9 +++---- .../service/impl/PinYinServiceImpl.java | 3 ++- .../user/controller/FeedbackController.java | 3 ++- .../user/controller/UserController.java | 10 ++++---- .../business/user/dao/FeedbackDao.java | 5 +++- .../bookmark/business/user/dao/UserDao.java | 3 ++- .../business/user/entity/Feedback.java | 3 ++- .../user/service/FeedbackService.java | 3 ++- .../business/user/service/OAuthService.java | 8 ------- .../business/user/service/OauthService.java | 19 +++++++++++++++ .../business/user/service/UserService.java | 2 ++ .../service/impl/FeedbackServiceImpl.java | 9 +++++-- ...ServiceImpl.java => OauthServiceImpl.java} | 19 +++++++-------- .../user/service/impl/UserApiImpl.java | 4 ++++ .../user/service/impl/UserServiceImpl.java | 6 ++++- .../vo/{OAuthBody.java => OauthBody.java} | 2 +- 24 files changed, 108 insertions(+), 49 deletions(-) delete mode 100644 bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/service/OAuthService.java create mode 100644 bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/service/OauthService.java rename bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/service/impl/{OAuthServiceImpl.java => OauthServiceImpl.java} (88%) rename bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/vo/{OAuthBody.java => OauthBody.java} (93%) diff --git a/bookMarkService/business/api/src/main/java/com/fanxb/bookmark/business/api/BookmarkApi.java b/bookMarkService/business/api/src/main/java/com/fanxb/bookmark/business/api/BookmarkApi.java index 5a1bdfd..ed7b048 100644 --- a/bookMarkService/business/api/src/main/java/com/fanxb/bookmark/business/api/BookmarkApi.java +++ b/bookMarkService/business/api/src/main/java/com/fanxb/bookmark/business/api/BookmarkApi.java @@ -21,6 +21,7 @@ public interface BookmarkApi { * @author fanxb * @param delete 是否删除问题数据 * @param userId userId + * @return 返回删除的数据 * @date 2021/3/17 **/ Set dealBadBookmark(boolean delete, int userId); diff --git a/bookMarkService/business/api/src/main/java/com/fanxb/bookmark/business/api/UserApi.java b/bookMarkService/business/api/src/main/java/com/fanxb/bookmark/business/api/UserApi.java index 60c4589..4241812 100644 --- a/bookMarkService/business/api/src/main/java/com/fanxb/bookmark/business/api/UserApi.java +++ b/bookMarkService/business/api/src/main/java/com/fanxb/bookmark/business/api/UserApi.java @@ -1,5 +1,9 @@ package com.fanxb.bookmark.business.api; +/** + * @author fanxb + * @date 2021/8/20 下午2:12 + */ public interface UserApi { /** * 版本自增 diff --git a/bookMarkService/business/bookmark/src/main/java/com/fanxb/bookmark/business/bookmark/consumer/BookmarkDeleteEsConsumer.java b/bookMarkService/business/bookmark/src/main/java/com/fanxb/bookmark/business/bookmark/consumer/BookmarkDeleteEsConsumer.java index 521206d..0a3998c 100644 --- a/bookMarkService/business/bookmark/src/main/java/com/fanxb/bookmark/business/bookmark/consumer/BookmarkDeleteEsConsumer.java +++ b/bookMarkService/business/bookmark/src/main/java/com/fanxb/bookmark/business/bookmark/consumer/BookmarkDeleteEsConsumer.java @@ -13,7 +13,8 @@ import java.util.List; /** * Created with IntelliJ IDEA - * Created By Fxb + * + * @author fanxb * Date: 2020/3/29 * Time: 13:08 */ diff --git a/bookMarkService/business/bookmark/src/main/java/com/fanxb/bookmark/business/bookmark/controller/BookmarkBackupController.java b/bookMarkService/business/bookmark/src/main/java/com/fanxb/bookmark/business/bookmark/controller/BookmarkBackupController.java index 366e915..2763caa 100644 --- a/bookMarkService/business/bookmark/src/main/java/com/fanxb/bookmark/business/bookmark/controller/BookmarkBackupController.java +++ b/bookMarkService/business/bookmark/src/main/java/com/fanxb/bookmark/business/bookmark/controller/BookmarkBackupController.java @@ -21,7 +21,7 @@ import org.springframework.web.bind.annotation.RestController; @RequestMapping("/bookmarkBackup") public class BookmarkBackupController { - private BookmarkBackupService backupService; + private final BookmarkBackupService backupService; @Autowired public BookmarkBackupController(BookmarkBackupServiceImpl backupService) { @@ -31,7 +31,7 @@ public class BookmarkBackupController { @PostMapping("/mysqlToEs") public Result backupToEs() { //异步执行同步任务 - ThreadPoolUtil.execute(() -> backupService.backupToEs()); + ThreadPoolUtil.execute(backupService::backupToEs); return Result.success(null); } } diff --git a/bookMarkService/business/bookmark/src/main/java/com/fanxb/bookmark/business/bookmark/dao/BookmarkDao.java b/bookMarkService/business/bookmark/src/main/java/com/fanxb/bookmark/business/bookmark/dao/BookmarkDao.java index 8d8678e..0486089 100644 --- a/bookMarkService/business/bookmark/src/main/java/com/fanxb/bookmark/business/bookmark/dao/BookmarkDao.java +++ b/bookMarkService/business/bookmark/src/main/java/com/fanxb/bookmark/business/bookmark/dao/BookmarkDao.java @@ -187,6 +187,7 @@ public interface BookmarkDao extends BaseMapper { /** * 批量更新searchKey * + * @param list list * @author fanxb * @date 2020/3/22 22:08 */ @@ -213,16 +214,28 @@ public interface BookmarkDao extends BaseMapper { @Update("update bookmark set visitNum=visitNum+1 where userId=#{userId} and bookmarkId=#{bookmarkId}") void updateVisitNum(VisitNumPlus item); + /** + * 查询用户最常访问的几个书签 + * + * @param userId 用户id + * @param num num + * @return java.util.List + * @author fanxb + * @date 2021/8/20 上午11:52 + */ @Select("select bookmarkId,name,url,icon from bookmark where userId=#{userId} and type=0 order by visitNum desc limit 0,#{num}") List selectPopular(@Param("userId") int userId, @Param("num") int num); /** * 获取某用户无icon的条目 * + * @param userId userId + * @param start 开始 + * @param size 数量 * @return java.util.List * @author fanxb - * @date 2021/3/11 - **/ + * @date 2021/8/20 下午12:02 + */ @Select("select userId,bookmarkId,url,icon from bookmark where userId=#{userId} and icon='' order by bookmarkId asc limit #{start},#{size}") List selectUserNoIcon(@Param("userId") int userId, @Param("start") int start, @Param("size") int size); @@ -238,12 +251,13 @@ public interface BookmarkDao extends BaseMapper { void updateIcon(@Param("bookmarkId") int bookmarkId, @Param("icon") String icon); /** - * 获取某用户所有的id,bookmark + * 查询一个用户全部的书签路径 * * @param userId userId + * @return java.util.List * @author fanxb - * @date 2021/3/17 - **/ + * @date 2021/8/20 上午11:58 + */ @Select("select bookmarkId,path from bookmark where userId=#{userId}") List selectBookmarkIdPathByUserId(int userId); diff --git a/bookMarkService/business/bookmark/src/main/java/com/fanxb/bookmark/business/bookmark/entity/PinYinBody.java b/bookMarkService/business/bookmark/src/main/java/com/fanxb/bookmark/business/bookmark/entity/PinYinBody.java index 2507dc8..e131f56 100644 --- a/bookMarkService/business/bookmark/src/main/java/com/fanxb/bookmark/business/bookmark/entity/PinYinBody.java +++ b/bookMarkService/business/bookmark/src/main/java/com/fanxb/bookmark/business/bookmark/entity/PinYinBody.java @@ -8,7 +8,8 @@ import java.util.List; /** * Created with IntelliJ IDEA - * Created By Fxb + * + * @author fanxb * Date: 2020/3/19 * Time: 0:05 */ diff --git a/bookMarkService/business/bookmark/src/main/java/com/fanxb/bookmark/business/bookmark/service/BookmarkBackupService.java b/bookMarkService/business/bookmark/src/main/java/com/fanxb/bookmark/business/bookmark/service/BookmarkBackupService.java index 323cac1..c885a45 100644 --- a/bookMarkService/business/bookmark/src/main/java/com/fanxb/bookmark/business/bookmark/service/BookmarkBackupService.java +++ b/bookMarkService/business/bookmark/src/main/java/com/fanxb/bookmark/business/bookmark/service/BookmarkBackupService.java @@ -1,8 +1,7 @@ package com.fanxb.bookmark.business.bookmark.service; /** - * Created with IntelliJ IDEA - * Created By Fxb + * @author fanxb * Date: 2020/3/29 * Time: 12:43 */ @@ -20,6 +19,7 @@ public interface BookmarkBackupService { /** * Description: 将某个用户的书签数据mysql同步到es中 * + * @param userId 用户id * @author fanxb * @date 2019/7/26 11:27 */ diff --git a/bookMarkService/business/bookmark/src/main/java/com/fanxb/bookmark/business/bookmark/service/BookmarkService.java b/bookMarkService/business/bookmark/src/main/java/com/fanxb/bookmark/business/bookmark/service/BookmarkService.java index 514c010..a390bcb 100644 --- a/bookMarkService/business/bookmark/src/main/java/com/fanxb/bookmark/business/bookmark/service/BookmarkService.java +++ b/bookMarkService/business/bookmark/src/main/java/com/fanxb/bookmark/business/bookmark/service/BookmarkService.java @@ -11,7 +11,8 @@ import java.util.Set; /** * Created with IntelliJ IDEA - * Created By Fxb + * + * @author fanxb * Date: 2020/3/29 * Time: 12:25 */ @@ -48,6 +49,8 @@ public interface BookmarkService { * * @param stream 输入流 * @param path 存放路径 + * @param userId userId + * @throws Exception 各种异常 * @author fanxb * @date 2019/7/9 18:44 */ @@ -68,6 +71,7 @@ public interface BookmarkService { * * @param userId userId * @param bookmark bookmark + * @return 更新后的icon * @author fanxb * @date 2019/7/17 14:42 */ diff --git a/bookMarkService/business/bookmark/src/main/java/com/fanxb/bookmark/business/bookmark/service/PinYinService.java b/bookMarkService/business/bookmark/src/main/java/com/fanxb/bookmark/business/bookmark/service/PinYinService.java index 09a74ac..32521fe 100644 --- a/bookMarkService/business/bookmark/src/main/java/com/fanxb/bookmark/business/bookmark/service/PinYinService.java +++ b/bookMarkService/business/bookmark/src/main/java/com/fanxb/bookmark/business/bookmark/service/PinYinService.java @@ -6,7 +6,8 @@ import java.util.List; /** * Created with IntelliJ IDEA - * Created By Fxb + * + * @author fanxb * Date: 2020/3/18 * Time: 23:47 */ @@ -15,15 +16,15 @@ public interface PinYinService { /** * 分隔符 */ - static final String PARTITION = "||"; + String PARTITION = "||"; /** * 拼音接口路径 */ - static final String PATH = "/pinyinChange"; + String PATH = "/pinyinChange"; /** * 分页查询页大小 */ - static final int SIZE = 500; + int SIZE = 500; /** * 功能描述: 首次上线用于全量初始化 diff --git a/bookMarkService/business/bookmark/src/main/java/com/fanxb/bookmark/business/bookmark/service/impl/PinYinServiceImpl.java b/bookMarkService/business/bookmark/src/main/java/com/fanxb/bookmark/business/bookmark/service/impl/PinYinServiceImpl.java index cdb35fa..d19363f 100644 --- a/bookMarkService/business/bookmark/src/main/java/com/fanxb/bookmark/business/bookmark/service/impl/PinYinServiceImpl.java +++ b/bookMarkService/business/bookmark/src/main/java/com/fanxb/bookmark/business/bookmark/service/impl/PinYinServiceImpl.java @@ -27,7 +27,8 @@ import java.util.stream.Collectors; /** * Created with IntelliJ IDEA - * Created By Fxb + * + * @author fanxb * Date: 2020/3/18 * Time: 23:48 */ diff --git a/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/controller/FeedbackController.java b/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/controller/FeedbackController.java index 5d5483d..734f593 100644 --- a/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/controller/FeedbackController.java +++ b/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/controller/FeedbackController.java @@ -12,7 +12,8 @@ import org.springframework.web.bind.annotation.RestController; /** * Created with IntelliJ IDEA - * Created By Fxb + * + * @author fanxb * Date: 2020/3/10 * Time: 23:16 */ diff --git a/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/controller/UserController.java b/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/controller/UserController.java index 26e3458..523e78f 100644 --- a/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/controller/UserController.java +++ b/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/controller/UserController.java @@ -1,10 +1,10 @@ package com.fanxb.bookmark.business.user.controller; import com.alibaba.fastjson.JSONObject; -import com.fanxb.bookmark.business.user.service.OAuthService; +import com.fanxb.bookmark.business.user.service.OauthService; import com.fanxb.bookmark.business.user.service.UserService; import com.fanxb.bookmark.business.user.vo.LoginBody; -import com.fanxb.bookmark.business.user.vo.OAuthBody; +import com.fanxb.bookmark.business.user.vo.OauthBody; import com.fanxb.bookmark.business.user.vo.RegisterBody; import com.fanxb.bookmark.business.user.service.impl.UserServiceImpl; import com.fanxb.bookmark.common.entity.Result; @@ -28,11 +28,11 @@ import javax.validation.Valid; public class UserController { private final UserServiceImpl userServiceImpl; - private final OAuthService oAuthService; + private final OauthService oAuthService; private final UserService userService; @Autowired - public UserController(UserServiceImpl userServiceImpl, OAuthService oAuthService, UserService userService) { + public UserController(UserServiceImpl userServiceImpl, OauthService oAuthService, UserService userService) { this.userServiceImpl = userServiceImpl; this.oAuthService = oAuthService; this.userService = userService; @@ -142,7 +142,7 @@ public class UserController { * @date 2021/3/10 */ @PostMapping("oAuthLogin") - public Result oAuthLogin(@RequestBody OAuthBody body) { + public Result oAuthLogin(@RequestBody OauthBody body) { return Result.success(oAuthService.oAuthCheck(body)); } diff --git a/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/dao/FeedbackDao.java b/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/dao/FeedbackDao.java index e03a423..82b915b 100644 --- a/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/dao/FeedbackDao.java +++ b/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/dao/FeedbackDao.java @@ -3,13 +3,16 @@ package com.fanxb.bookmark.business.user.dao; import com.fanxb.bookmark.business.user.entity.Feedback; import org.apache.ibatis.annotations.Insert; import org.apache.ibatis.annotations.Mapper; +import org.springframework.stereotype.Component; /** * Created with IntelliJ IDEA - * Created By Fxb + * + * @author fanxb * Date: 2020/3/10 * Time: 23:14 */ +@Component public interface FeedbackDao { /** diff --git a/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/dao/UserDao.java b/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/dao/UserDao.java index 1f39c0f..5c4a38c 100644 --- a/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/dao/UserDao.java +++ b/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/dao/UserDao.java @@ -62,7 +62,8 @@ public interface UserDao { /** * Description: 根据用户id查询用户信息 * - * @param userId userId + * @param userId userId + * @param githubId githubId * @return com.fanxb.bookmark.common.entity.User * @author fanxb * @date 2019/7/30 16:08 diff --git a/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/entity/Feedback.java b/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/entity/Feedback.java index 599811f..23a8537 100644 --- a/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/entity/Feedback.java +++ b/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/entity/Feedback.java @@ -6,7 +6,8 @@ import javax.validation.constraints.NotEmpty; /** * Created with IntelliJ IDEA - * Created By Fxb + * + * @author fanxb * Date: 2020/3/10 * Time: 23:13 */ diff --git a/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/service/FeedbackService.java b/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/service/FeedbackService.java index eaf1f05..cb081b3 100644 --- a/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/service/FeedbackService.java +++ b/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/service/FeedbackService.java @@ -4,7 +4,8 @@ import com.fanxb.bookmark.business.user.entity.Feedback; /** * Created with IntelliJ IDEA - * Created By Fxb + * + * @author fanxb * Date: 2020/3/10 * Time: 23:17 */ diff --git a/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/service/OAuthService.java b/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/service/OAuthService.java deleted file mode 100644 index a7780ef..0000000 --- a/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/service/OAuthService.java +++ /dev/null @@ -1,8 +0,0 @@ -package com.fanxb.bookmark.business.user.service; - -import com.fanxb.bookmark.business.user.vo.OAuthBody; - -public interface OAuthService { - - String oAuthCheck(OAuthBody body); -} diff --git a/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/service/OauthService.java b/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/service/OauthService.java new file mode 100644 index 0000000..cdcc110 --- /dev/null +++ b/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/service/OauthService.java @@ -0,0 +1,19 @@ +package com.fanxb.bookmark.business.user.service; + +import com.fanxb.bookmark.business.user.vo.OauthBody; + +/** + * @author fanxb + * @date 2021/8/20 下午2:13 + */ +public interface OauthService { + /** + * oauth登陆校验 + * + * @param body body + * @return java.lang.String + * @author fanxb + * @date 2021/8/20 下午2:13 + */ + String oAuthCheck(OauthBody body); +} diff --git a/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/service/UserService.java b/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/service/UserService.java index 3dd008d..d1e43e2 100644 --- a/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/service/UserService.java +++ b/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/service/UserService.java @@ -38,6 +38,7 @@ public interface UserService { /** * 获取当前用户的version * + * @param userId userId * @return int * @author fanxb * @date 2021/3/11 @@ -56,6 +57,7 @@ public interface UserService { * 检查所有用户的问题书签数据 * * @param delete 是否删除问题数据 + * @return 返回用户删除的数据 * @author fanxb * @date 2021/3/17 **/ diff --git a/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/service/impl/FeedbackServiceImpl.java b/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/service/impl/FeedbackServiceImpl.java index b9da824..6b3f6bf 100644 --- a/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/service/impl/FeedbackServiceImpl.java +++ b/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/service/impl/FeedbackServiceImpl.java @@ -9,14 +9,19 @@ import org.springframework.stereotype.Service; /** * Created with IntelliJ IDEA - * Created By Fxb + * + * @author fanxb * Date: 2020/3/10 * Time: 23:17 */ @Service public class FeedbackServiceImpl implements FeedbackService { + private final FeedbackDao feedbackDao; + @Autowired - private FeedbackDao feedbackDao; + public FeedbackServiceImpl(FeedbackDao feedbackDao) { + this.feedbackDao = feedbackDao; + } @Override public void addOne(Feedback feedback) { diff --git a/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/service/impl/OAuthServiceImpl.java b/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/service/impl/OauthServiceImpl.java similarity index 88% rename from bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/service/impl/OAuthServiceImpl.java rename to bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/service/impl/OauthServiceImpl.java index c2779cc..475e897 100644 --- a/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/service/impl/OAuthServiceImpl.java +++ b/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/service/impl/OauthServiceImpl.java @@ -1,12 +1,11 @@ package com.fanxb.bookmark.business.user.service.impl; -import cn.hutool.core.util.RandomUtil; import cn.hutool.core.util.StrUtil; import com.alibaba.fastjson.JSONObject; import com.fanxb.bookmark.business.user.dao.UserDao; -import com.fanxb.bookmark.business.user.service.OAuthService; +import com.fanxb.bookmark.business.user.service.OauthService; import com.fanxb.bookmark.business.user.service.UserService; -import com.fanxb.bookmark.business.user.vo.OAuthBody; +import com.fanxb.bookmark.business.user.vo.OauthBody; import com.fanxb.bookmark.common.constant.Constant; import com.fanxb.bookmark.common.entity.User; import com.fanxb.bookmark.common.exception.CustomException; @@ -33,7 +32,7 @@ import static com.fanxb.bookmark.business.user.service.UserService.SHORT_EXPIRE_ **/ @Service @Slf4j -public class OAuthServiceImpl implements OAuthService { +public class OauthServiceImpl implements OauthService { @Value("${OAuth.github.clientId}") private String githubClientId; @@ -43,16 +42,16 @@ public class OAuthServiceImpl implements OAuthService { private final UserService userService; @Autowired - public OAuthServiceImpl(UserDao userDao, UserService userService) { + public OauthServiceImpl(UserDao userDao, UserService userService) { this.userDao = userDao; this.userService = userService; } @Override @Transactional(rollbackFor = Exception.class) - public String oAuthCheck(OAuthBody body) { + public String oAuthCheck(OauthBody body) { User current, other = new User(); - if (StrUtil.equals(body.getType(), OAuthBody.GITHUB)) { + if (StrUtil.equals(body.getType(), OauthBody.GITHUB)) { Map header = new HashMap<>(2); header.put("accept", "application/json"); String url = "https://github.com/login/oauth/access_token?client_id=" + githubClientId + "&client_secret=" + githubSecret + "&code=" + body.getCode(); @@ -65,7 +64,7 @@ public class OAuthServiceImpl implements OAuthService { JSONObject userInfo = HttpUtil.getObj("https://api.github.com/user", header, true); other.setGithubId(userInfo.getLong("id")); if (other.getGithubId() == null) { - log.error("github返回异常:{}", userInfo.toString()); + log.error("github返回异常:{}", userInfo); throw new CustomException("登陆异常，请稍后重试"); } other.setEmail(userInfo.getString("email")); @@ -78,7 +77,7 @@ public class OAuthServiceImpl implements OAuthService { } else { throw new CustomException("不支持的登陆方式" + body.getType()); } - User newest = dealOAuth(current, other); + User newest = dealOauth(current, other); return JwtUtil.encode(Collections.singletonMap("userId", String.valueOf(newest.getUserId())), Constant.jwtSecret , body.isRememberMe() ? LONG_EXPIRE_TIME : SHORT_EXPIRE_TIME); } @@ -92,7 +91,7 @@ public class OAuthServiceImpl implements OAuthService { * @author fanxb * @date 2021/3/11 **/ - private User dealOAuth(User current, User other) { + private User dealOauth(User current, User other) { if (current == null) { //判断用户名是否可用 if (userDao.usernameExist(other.getUsername())) { diff --git a/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/service/impl/UserApiImpl.java b/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/service/impl/UserApiImpl.java index def3508..3781649 100644 --- a/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/service/impl/UserApiImpl.java +++ b/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/service/impl/UserApiImpl.java @@ -5,6 +5,10 @@ import com.fanxb.bookmark.business.user.dao.UserDao; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.stereotype.Service; +/** + * @author fanxb + * @date 2021/8/20 下午2:15 + */ @Service public class UserApiImpl implements UserApi { private final UserDao userDao; diff --git a/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/service/impl/UserServiceImpl.java b/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/service/impl/UserServiceImpl.java index e39f74e..58e4807 100644 --- a/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/service/impl/UserServiceImpl.java +++ b/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/service/impl/UserServiceImpl.java @@ -39,6 +39,10 @@ import java.util.concurrent.TimeUnit; @Service @Slf4j public class UserServiceImpl implements UserService { + /** + * 登陆最大重试次数 + */ + private static final int LOGIN_COUNT = 5; private final UserDao userDao; private final StringRedisTemplate redisTemplate; @@ -115,7 +119,7 @@ public class UserServiceImpl implements UserService { public String login(LoginBody body) { String key = RedisConstant.getUserFailCountKey(body.getStr()); String count = redisTemplate.opsForValue().get(key); - if (count != null && Integer.parseInt(count) >= 5) { + if (count != null && Integer.parseInt(count) >= LOGIN_COUNT) { redisTemplate.expire(key, 30, TimeUnit.MINUTES); throw new FormDataException("您已连续输错密码5次，请30分钟后再试，或联系管理员处理"); } diff --git a/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/vo/OAuthBody.java b/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/vo/OauthBody.java similarity index 93% rename from bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/vo/OAuthBody.java rename to bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/vo/OauthBody.java index 739ae40..c55fd07 100644 --- a/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/vo/OAuthBody.java +++ b/bookMarkService/business/user/src/main/java/com/fanxb/bookmark/business/user/vo/OauthBody.java @@ -9,7 +9,7 @@ import lombok.Data; * @date 2021/3/10 **/ @Data -public class OAuthBody { +public class OauthBody { public static final String GITHUB = "github"; /** * 类别